From 457d7bd272ceeed13bdb7392125b6ba2688efe93 Mon Sep 17 00:00:00 2001
From: bovirus <1262554+bovirus@users.noreply.github.com>
Date: Wed, 11 Oct 2023 11:05:52 +0200
Subject: [PATCH] Inno Setup script improvement

Usa many variables in define pre.processor instruction
Add many option to Setup sectioN
Separate all languages definitions/custom strings in a separate file
---
 Dist/InnoSetup/winmute-setup-languages.iss |  8 +++++
 Dist/InnoSetup/winmute-setup.iss           | 42 ++++++++++++++--------
 2 files changed, 35 insertions(+), 15 deletions(-)
 create mode 100644 Dist/InnoSetup/winmute-setup-languages.iss

diff --git a/Dist/InnoSetup/winmute-setup-languages.iss b/Dist/InnoSetup/winmute-setup-languages.iss
new file mode 100644
index 0000000..3cc6d53
--- /dev/null
+++ b/Dist/InnoSetup/winmute-setup-languages.iss
@@ -0,0 +1,8 @@
+[CustomMessages]
+english.StartpAppLogon=Start WinMute when you log on
+;italian.StartpAppLogon=Esegui WinMute all'accesso
+
+[Languages]
+Name: "english"; MessagesFile: "compiler:Default.isl";           InfoBeforeFile: "info-before.txt";
+Name: "german";  MessagesFile: "compiler:Languages\German.isl";  InfoBeforeFile: "info-before.txt";
+;Name: "italian";  MessagesFile: "compiler:Languages\Italian.isl";  InfoBeforeFile: "info-before.ita.txt";
diff --git a/Dist/InnoSetup/winmute-setup.iss b/Dist/InnoSetup/winmute-setup.iss
index 2bff0ab..8f168c2 100644
--- a/Dist/InnoSetup/winmute-setup.iss
+++ b/Dist/InnoSetup/winmute-setup.iss
@@ -1,44 +1,55 @@
-#define MyAppName "WinMute"
-#define MyAppVersion "2.4.1.0"
+#include               ".\winmute-setup-languages.iss"
+#define MyAppName      "WinMute"
+#define MyAppExeName   "..\bin\" + MyAppName + ".exe"
+#define MyAppVersion   GetVersionNumbersString(MyAppExeName)
 #define MyAppPublisher "LX-Systems"
-#define MyAppURL "https://www.lx-s.de/winmute"
-#define MyAppExeName "WinMute.exe"
-#define MyAppMutex "LxSystemsWinMute"
+#define MyAppURL       "https://www.lx-s.de/winmute"
+#define MyAppExeName   "WinMute.exe"
+#define MyAppMutex     "LxSystemsWinMute"
+#define CurrentYear    GetDateTimeString('yyyy','','')
 
 [Setup]
 AppId={{D2E8F9EF-11E7-418B-B9B7-A35A69A30490}
 AppName={#MyAppName}
 AppVersion={#MyAppVersion}
 AppVerName={#MyAppName} {#MyAppVersion}
+
+AppCopyright=(c) {#CurrentYear} {#MyAppPublisher}
 AppPublisher={#MyAppPublisher}
 AppPublisherURL={#MyAppURL}
 AppSupportURL={#MyAppURL}
 AppUpdatesURL={#MyAppURL}
+
+VersionInfoDescription={#MyAppName} installer
+VersionInfoProductName={#MyAppName}
+VersionInfoVersion={#MyAppVersion}
+
+UninstallDisplayName={#MyAppName}
+UninstallDisplayIcon={app}\{#MyAppExeName}.exe
+
+WizardStyle=modern
+ShowLanguageDialog=yes
+UsePreviousLanguage=no
+LanguageDetectionMethod=uilanguage
+
 DefaultDirName={autopf}\{#MyAppPublisher}\{#MyAppName}
 DisableProgramGroupPage=yes
-LicenseFile=..\bin\license.txt
+LicenseFile=..\bin\license.rtf
 InfoBeforeFile=info-before.txt
 AppMutex={#MyAppMutex}
 SetupMutex={#MyAppMutex}Setup
-PrivilegesRequiredOverridesAllowed=dialog
+;PrivilegesRequiredOverridesAllowed=dialog
 PrivilegesRequired=lowest
 OutputDir=..\bin\
 OutputBaseFilename=WinMuteSetup
 SetupIconFile=..\..\WinMute\icons\app.ico
-UninstallDisplayIcon={app}\{#MyAppExeName}.exe
 ArchitecturesInstallIn64BitMode=x64
 Compression=lzma
 SolidCompression=yes
-WizardStyle=modern
-ShowLanguageDialog=auto
-
-[Languages]
-Name: "en"; MessagesFile: "compiler:Default.isl"
-Name: "de"; MessagesFile: "compiler:Languages\German.isl"
 
 [Tasks]
 Name: "desktopicon"; Description: "{cm:CreateDesktopIcon}"; GroupDescription: "{cm:AdditionalIcons}"; Flags: unchecked
-Name: "autostart" ; Description: "Start WinMute when you log on" ; GroupDescription: "Autostart"; Flags: unchecked
+Name: "autostart" ; Description: "{cm:StartpAppLogon}" ; GroupDescription: "Autostart"; Flags: unchecked
 
 [Files]
 Source: "..\bin\{#MyAppExeName}"; DestDir: "{app}"; Flags: ignoreversion
@@ -62,3 +73,4 @@ Root: HKCU; Subkey: "Software\Microsoft\Windows\CurrentVersion\Run"; ValueType:
 
 [Run]
 Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
+
-- 
2.43.0